Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(list): Add notifyAction adapter for action on list item. #4144

Merged
merged 10 commits into from
Jan 25, 2019
Merged

feat(list): Add notifyAction adapter for action on list item. #4144

merged 10 commits into from
Jan 25, 2019

Conversation

abhiomkar
Copy link
Collaborator

@abhiomkar abhiomkar commented Dec 5, 2018 •
edited
Loading

notifyAction adapter method is introduced to notify on user action including keyboard and mouse. This could've been notifySelected but the a list can also be a checkbox variant where it can have multiple selections and an action could also cause unselect.

BREAKING CHANGE: Removed adapter method followHref and used native anchor element behaviour to follow href on Enter & click. Components that use MDC List should use its new custom event.

Changes required for #3481

@abhiomkar abhiomkar requested a review from kfranqueiro December 5, 2018 09:57
@mdc-web-bot
Copy link
Collaborator

All 691 screenshot tests passed for commit b39a6b1 vs. master! 💯🎉

@codecov-io
Copy link

codecov-io commented Dec 6, 2018 •
edited
Loading

Codecov Report

Merging #4144 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4144   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files         127      127           
  Lines        5705     5705           
  Branches      762      762           
=======================================
  Hits         5624     5624           
  Misses         81       81
Impacted Files Coverage Δ
packages/mdc-list/constants.js 100% <ø> (ø) ⬆️
packages/mdc-list/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-list/index.js 98.47% <100%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb8b8f6...f127152. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 691 screenshot tests passed for commit 1d4f896 vs. master! 💯🎉

@kfranqueiro kfranqueiro mentioned this pull request Dec 6, 2018
Merged
@mdc-web-bot
Copy link
Collaborator

All 691 screenshot tests passed for commit a7e8edd vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 691 screenshot tests passed for commit 5c93287 vs. master! 💯🎉

@abhiomkar abhiomkar assigned kfranqueiro and unassigned kfranqueiro Dec 20, 2018
kfranqueiro
kfranqueiro reviewed Jan 2, 2019
View reviewed changes
packages/mdc-list/README.md Show resolved Hide resolved
packages/mdc-list/foundation.js Outdated Show resolved Hide resolved
@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit 20d069e vs. master! 💯🎉

kfranqueiro
kfranqueiro approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@kfranqueiro kfranqueiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, presuming tests pass now

@kfranqueiro
Copy link
Contributor

PS: I think this should probably be considered a feat in the commit subject, along with the breaking change in the commit description.

@abhiomkar abhiomkar changed the title fix(list): Add notifyAction adapter for action on list item. feat(list): Add notifyAction adapter for action on list item. Jan 25, 2019
@mdc-web-bot
Copy link
Collaborator

All 758 screenshot tests passed for commit f127152 vs. master! 💯🎉

@abhiomkar abhiomkar merged commit 6ed35b1 into master Jan 25, 2019
@abhiomkar abhiomkar mentioned this pull request Feb 1, 2019
Closed
@jamesmfriedman jamesmfriedman mentioned this pull request Feb 5, 2019
Closed
24 tasks
@acdvorak acdvorak mentioned this pull request Feb 5, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kfranqueiro kfranqueiro kfranqueiro approved these changes

Assignees

@kfranqueiro kfranqueiro

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@abhiomkar @mdc-web-bot @codecov-io @kfranqueiro @googlebot